Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some questions about sync with upstream #31

Open
MrNaif2018 opened this issue Nov 18, 2024 · 1 comment
Open

Some questions about sync with upstream #31

MrNaif2018 opened this issue Nov 18, 2024 · 1 comment

Comments

@MrNaif2018
Copy link

Hi! I'm the creator of Bitcart: opensource payment processor which supports many coins via electrums.
Our users suggested to take a look at dash.
I got some initial success, but there are some things missing:
e.g. the aiorpcx library requirement is not updated, so it fails to connect to network when a newer version from other electrums is in environment
I had many issues with bls library
The package seems to require python-bls library which didn't want to compile properly
But I think package has a dependency on blspy library as well? Because some names imported from bls_py were not found

from bls_py import bls

Like there's bls_py package being python-bls, and blypy package being blspy itself. Maybe blspy package can be used, as it seems to be more updated?

Also the lib seems to miss some fixes we need, e.g. spesmilo/electrum#7936

The best would be to regularly rebase against base electrum. A bit of a problem is that electrum has lightning enabled and dash probably doesn't support lightning network. So to avoid many rebase changes maybe it could be turned off somewhere at the core
I don't know how much does the current repo lag behind upstream. Let me know if we can somehow work that out!

@pshenmic
Copy link
Owner

Hey,

Yeah, the Dash Core protocol slightly changed bls library not a long ago, and I had to implelemnt it in the Electrum Dash, it is kinda complicated to build, I admit. Actually, let me hit you in TG real quick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants