Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation not working if using svelte beyond v3.6.4 #224

Closed
si3nloong opened this issue Jul 13, 2019 · 6 comments
Closed

Navigation not working if using svelte beyond v3.6.4 #224

si3nloong opened this issue Jul 13, 2019 · 6 comments

Comments

@si3nloong
Copy link

Screenshot 2019-07-14 at 12 51 48 AM

@pshrmn
Copy link
Owner

pshrmn commented Jul 13, 2019

Can you show the code where you render the Link? Also, did this work with Svelte <3.6.4?

@pshrmn
Copy link
Owner

pshrmn commented Jul 13, 2019

There error that you are referring to is this line, which makes me think that your router context isn't correct. I would recommend taking a look at some of the examples (the basic example is a good reference) to make sure that you have the router setup correctly.

@si3nloong
Copy link
Author

Yes, i have the same setup, it working on svelte v3.6.4, but not after, try to use svelte v3.6.5 in https://codesandbox.io/s/curi-examplebasic-svelte-mvql4, it will not working as expected

@pshrmn
Copy link
Owner

pshrmn commented Jul 13, 2019

Are you getting the same issues locally? I ran the basic example locally with Svelte 3.6.5 and it worked.

@si3nloong
Copy link
Author

I figure out there would be other component issue. Nevertheless, it reproduce another new error.
Screenshot 2019-07-14 at 12 10 51 PM

I think it probably related to this issue.
sveltejs/svelte#3165

@pshrmn
Copy link
Owner

pshrmn commented Jul 14, 2019

Are you implementing some sort of transition in your application? I don't think that that error is coming from @curi/svelte. Also, that issue implies that the error is gone in 3.6.7; have you tested that version?

@pshrmn pshrmn closed this as completed Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants