Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: --github-pull-requests-closed doesn't seem to work #371

Open
bsipocz opened this issue Sep 26, 2024 · 1 comment
Open

BUG: --github-pull-requests-closed doesn't seem to work #371

bsipocz opened this issue Sep 26, 2024 · 1 comment

Comments

@bsipocz
Copy link

bsipocz commented Sep 26, 2024

--github-pull-requests-closed returns empty, even though I had my own PRs closed/merged as well as closed/merged other people's PRs both this week and last.

@bsipocz
Copy link
Author

bsipocz commented Sep 26, 2024

Ahh, OK, I see that it assumes that a PR was assigned to someone. However, that is a very strong workflow assumption, and it's not at all how any of the community libraries work in the scientific python ecosystem.

So, now I rephrase and ask for either some documentation clarification, e.g. mentioned 'assigned' in Pull requests closed on github; or have another category for PRs where either the PR or any of its commits are authored by the login person, or have another category where a PR is closed by the login person.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant