This repository has been archived by the owner on Apr 14, 2024. It is now read-only.
Use standard GRPC for Ostinato - Drone communication instead of custom RPC #305
Comments
pstavirs
added a commit
that referenced
this issue
May 12, 2020
Using static vars meant all connections were using the same static vars! A bug that has existed since 2009! This code is ugly, but since it is such a fundamental piece of code for every operation, no refactoring is being done except to convert the static vars to data members renaming where required to avoid name conflicts. The one exception is that `cumLen` which was a per hdr.type variable is now a single data member across all types. Since for a single connection messages will be sequential this is expected to work (fingers crossed!) For the future we should look at replacing the custom RPC code with GRPC (issue #305). Fixes #304
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
GRPC was not available when the Ostinato-Drone RPC was implemented.
Now that it is, we need to consider refactoring the whole RPC infra to use that instead. We need to first evaluate whether it is feasible i.e. all features are available e.g. notify, error, binblob etc.
In any case this will take a large effort and is risky considering the crucial role of RPC in Ostinato
The text was updated successfully, but these errors were encountered: