Skip to content
This repository has been archived by the owner on Apr 14, 2024. It is now read-only.

Stream stats does not work for packet size < 64 bytes #313

Open
pstavirs opened this issue Jul 12, 2020 · 2 comments
Open

Stream stats does not work for packet size < 64 bytes #313

pstavirs opened this issue Jul 12, 2020 · 2 comments

Comments

@pstavirs
Copy link
Owner

This is even if the signature protocol is configured with a valid GUID as the last protocol of the stream.

For packet sizes < 64 bytes the NIC will add padding - which gets added after the signature protocol so Ostinato does not recognize the signature since it expects signature to be the last few bytes in the packet.

Workaround is to add Pattern as the payload protocol before the special signature protocol -

image
@pstavirs pstavirs added this to the v1.2 milestone May 30, 2022
@pstavirs
Copy link
Owner Author

A mitigation could be to check this during pre-flight check and warn user

pstavirs added a commit that referenced this issue Jun 30, 2022
@pstavirs
Warn if sign proto may be followed by padding
06ad127 
For now, we check and tell the user. The actual fix should be for
sign proto to add padding before it's content, if required

Updates #313
@pstavirs
Copy link
Owner Author

A pre-flight check message has been added for now.

One possible fix is for the sign protocol to add any padding required before it's actual content.

@pstavirs pstavirs modified the milestones: v1.2, v1.3 Jun 30, 2022
@pstavirs pstavirs removed this from the v1.3 milestone Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pstavirs