Skip to content
This repository has been archived by the owner on Apr 14, 2024. It is now read-only.

Support pattern payload of size 0 #366

Open
pstavirs opened this issue Oct 31, 2023 · 0 comments
Open

Support pattern payload of size 0 #366

pstavirs opened this issue Oct 31, 2023 · 0 comments
Labels
Milestone

Comments

@pstavirs
Copy link
Owner

The pattern payload protocol framesize is variable and is calculated based on the frameLength and the sum of all protocol frame sizes.

However, when building the frame value, for a calculated size of 0, pattern payload still adds one byte. This is due to this very old code in payload.cpp (not sure why it was added) -

                    // FIXME: Hack! Bad! Bad! Very Bad!!!
                    if (dataLen <= 0)
                        dataLen = 1;
@pstavirs pstavirs added the bug label Oct 31, 2023
@pstavirs pstavirs added this to the v1.4 milestone Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant