Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer manifest is not currently being used #118

Open
psteiwer opened this issue Nov 3, 2022 · 0 comments
Open

Installer manifest is not currently being used #118

psteiwer opened this issue Nov 3, 2022 · 0 comments
Labels
bug Something isn't working
Milestone
v1.9

Comments

@psteiwer
Copy link
Owner

psteiwer commented Nov 3, 2022

PivotSubscriptions.Installer currently defines an Installer Manifest. However, the readme says to simply call PivotSubscriptions.Installer:RunInstaller(), which does not use the defined manifest.

I believe I remember that the manifest was not working as expected so I decided to use RunInstaller() instead. I do not remember what the issue with the Installer Manifest was so it would be good to review this and see if we can use it now
@psteiwer psteiwer added the bug Something isn't working label Nov 3, 2022
@psteiwer psteiwer added this to the v1.9 milestone Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.9
Development

No branches or pull requests
1 participant
@psteiwer