Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Equatable implementation of SubscriptionEffect #2

Open
pteasima opened this issue Aug 17, 2019 · 1 comment
Open

Improve Equatable implementation of SubscriptionEffect #2

pteasima opened this issue Aug 17, 2019 · 1 comment

Comments

@pteasima
Copy link
Owner

pteasima commented Aug 17, 2019 •
edited
Loading

With number of init overloads mounting up, the way I do equtability + type erasure is getting annoying.

https://github.com/pteasima/Uniflo/blob/master/Sources/Uniflo/SubscriptionEffect.swift

I should really look into AnyEquatable, but atm I dont really understand it and dont want to spend time on it.

PRs very much appreciated.
@pteasima
Copy link
Owner Author

could also use some more codereuse between the different overloads in general. Atm Im very mechanically copypasting cause getting reuse right for all three of perform,data and eq isnt straight forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pteasima