Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pygments styles not applied propperly for dark background styles #234

Open
ghost opened this issue Nov 12, 2018 · 2 comments
Open

Pygments styles not applied propperly for dark background styles #234

ghost opened this issue Nov 12, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Nov 12, 2018

For example :

https://ptpb.pw/9Ezk/bash?style=vim

According to the Pygments demo, this should render a black background styled code as seen here :

http://pygments.org/demo/6770298/?style=vim

Although, it only change the very background of the page (behind the code) to black but the code still have a white background. The syntax coloring of the code itself (the text) is ok, it's only the background.

I consider it as minor, but would be nice to see it fix. I might later fork and send a merge request when I get some spare time (could take a while) if nobody fix it in the meantime.

Good day.

@buhman
Copy link
Member

buhman commented Nov 12, 2018

Related: ptpb/pbs#2
ptpb/pbs@103f9c6

This might be a less compilation issue: pbs/code.less#L11; not sure.

The syntax coloring of the code itself (the text) is ok

It isn't, oddly.

screenshot

@buhman
Copy link
Member

buhman commented Nov 12, 2018

Fixing this (correctly) might involve client-side lighten/darken relative to the body background-color.

https://caniuse.com/#feat=css-filters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant