Malformatted Revision in getHeightOfRevision (Supabase Example)

[hagemon]

I’m integrating the Supabase example into my project ([email protected]), but inserting a new object results in the following error:

ERROR
malformatted revision: 
getHeightOfRevision@http://localhost:8888/bundle.js:47171:18
createRevision@http://localhost:8888/bundle.js:47178:69
@http://localhost:8888/bundle.js:64444:81

After inspecting createRevision, I found that _rev from previousDocData is used to generate newRevisionHeight. However, logging docData in preInsert (which corresponds to previousDocData in createRevision) shows that _rev is an empty string:

database.heroes.preInsert((docData) => {
    console.log((docData as any));
    docData.replicationRevision = createRevision(
        database.token,
        docData as any
    );
    return docData;
}, false);
/* output
{
    "name": "111",
    "color": "111",
    "updatedAt": 1738859213138,
    "replicationRevision": "1",
    "_meta": {
        "lwt": 1
    },
    "_deleted": false,
    "_attachments": {},
    "_rev": ""  // empty string here
}
*/

Manually adding _rev in the insert handler makes it work, but I’m unsure if this is a proper workaround:

(insertButton as any).onclick = async function () {
    const name = (document.querySelector('input[name="name"]') as any).value;
    const color = (document.querySelector('input[name="color"]') as any).value;
    const obj = {
        name: name,
        color: color,
        updatedAt: new Date().getTime(),
        replicationRevision: '1',
        _rev: '1-' + Math.random() // manually set the _rev
    };
    await database.heroes.insert(obj);
    (document.querySelector('input[name="name"]') as any).value = '';
    (document.querySelector('input[name="color"]') as any).value = '';
};

Is _rev expected to be set manually before insertion, or is this a bug in the example? Looking for guidance on the correct approach.

[pubkey]

No it should not be required to manually set revisions. Please make a PR with a unit test or something that reproduces your problem.

[hagemon]

Thanks for your reply!

I run the given unit tests in e2e.test.js with STORAGE=memory npm run test:e2e and set testcafe run in both safari and edge (because I don't use chrome) by editing package.json

{
    "test:e2e": "testcafe safari -e test/ --hostname localhost"
}

then I met the same error in TestCafe:

The output log:

> [email protected] test:e2e
> testcafe safari -e test/ --hostname localhost

 Running tests in:
 - Safari 18.1.1 / Sequoia 15

 Example page
start test insert/remove a hero
waitUntilPageIsLoaded()
logs:
{
  log: [
    '[HMR] Waiting for update signal from WDS...',
    'run() [object Object]',
    'storageKey: memory',
    'emitted heroes:',
    'minTimestamp: 0',
    'STATUS changed',
    'pull data:',
    'minTimestamp: 1738859777170',
    'pull data:'
  ],
  info: [
    '[webpack-dev-server] Server started: Hot Module Replacement enabled, Live Reloading enabled, Progress disabled, Overlay enabled.'
  ],
  warn: [
    'some dev mode warning'
  ],
  error: []
}
waitUntilPageIsLoaded(): done
logs:
{
  log: [
    '[HMR] Waiting for update signal from WDS...',
    'run() [object Object]',
    'storageKey: memory',
    'emitted heroes:',
    'minTimestamp: 0',
    'STATUS changed',
    'pull data:',
    'minTimestamp: 1738859777170',
    'pull data:'
  ],
  info: [
    '[webpack-dev-server] Server started: Hot Module Replacement enabled, Live Reloading enabled, Progress disabled, Overlay enabled.'
  ],
  warn: [
   'some dev mode warning...'
  ],
  error: []
}
deleteAll()
logs:
{
  log: [
    '[HMR] Waiting for update signal from WDS...',
    'run() [object Object]',
    'storageKey: memory',
    'emitted heroes:',
    'minTimestamp: 0',
    'STATUS changed',
    'pull data:',
    'minTimestamp: 1738859777170',
    'pull data:'
  ],
  info: [
    '[webpack-dev-server] Server started: Hot Module Replacement enabled, Live Reloading enabled, Progress disabled, Overlay enabled.'
  ],
  warn: [
    '-------------- RxDB dev-mode warning -------------------------------\n' +
      'you are seeing this because you use the RxDB dev-mode plugin https://rxdb.info/dev-mode.html?console=dev-mode \n' +
      'This is great in development mode, because it will run many checks to ensure\n' +
      'that you use RxDB correct. If you see this in production mode,\n' +
      'you did something wrong because the dev-mode plugin will decrease the performance.\n' +
      '\n' +
      '🤗 Hint: To get the most out of RxDB, check out the Premium Plugins\n' +
      'to get access to faster storages and more professional features: https://rxdb.info/premium/?console=dev-mode \n' +
      '\n' +
      'You can disable this warning by calling disableWarnings() from the dev-mode plugin.\n' +
      '---------------------------------------------------------------------'
  ],
  error: []
}
wait until the hero is emitted in the query
wait until the hero is emitted in the query
wait until the hero is emitted in the query
wait until the hero is emitted in the query
wait until the hero is emitted in the query
wait until the hero is emitted in the query
wait until the hero is emitted in the query
wait until the hero is emitted in the query
wait until the hero is emitted in the query
wait until the hero is emitted in the query
wait until the hero is emitted in the query
^CStopping TestCafe...

[pubkey]

Can you make a PR with that so that the CI fails? Shouldnt this also fail in chrome and firefox? Or is it browser specific?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed soon. Please update it or it may be closed to keep our repository organized. The best way is to add some more information or make a pull request with a test case. Also you might get help in fixing it at the RxDB Community Chat If you know you will continue working on this, just write any message to the issue (like "ping") to remove the stale tag.