Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment once we learn how CosmWasm message ordering works #39

Open
0xekez opened this issue Nov 24, 2022 · 1 comment
Open

Update comment once we learn how CosmWasm message ordering works #39

0xekez opened this issue Nov 24, 2022 · 1 comment

Comments

@0xekez
Copy link
Contributor

0xekez commented Nov 24, 2022

i think the CosmWasm documentation and code are a little self-contradictory about message ordering. this doesn't impact the functionality of this contract, but we'll need to update a comment in the code depending on the outcome of this:

CosmWasm/cosmwasm#1514

the comment:

https://github.com/public-awesome/ics721/blob/52852e07446c91983a91495e85103370f49814a7/contracts/cw-ics721-bridge/src/contract.rs#L356-L361

@Art3miX
Copy link
Collaborator

Art3miX commented Dec 28, 2022

If I understand the code correctly, there is 1 messages Vec, add_* functions are just helpers to append messages without the SubMsg wrapper.

Its safe to assume messages[0] will be called first and messages[1] second.

I wonder if it follows the whole tree of the SubMsg first, so if messages[0] has another SubMsg in it, will messages[0][0] be called before messages[1]? can we assume messages[0] full tree of messages is finished before messages[1] is called?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants