-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update en.yml #11460
base: main
Are you sure you want to change the base?
Update en.yml #11460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello @TildaDares @jywarren may i request this PR be merged with #11461 Thank you so much
If these tests pass, this is ready to merge! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11460 +/- ##
===========================================
- Coverage 83.21% 1.83% -81.38%
===========================================
Files 93 93
Lines 5772 8655 +2883
===========================================
- Hits 4803 159 -4644
- Misses 969 8496 +7527 |
config/locales/en.yml
Outdated
moderators</a> and we'll email you when it is published. In the meantime, if | ||
you have more to contribute, feel free to do so." | ||
thank_you_for_contribution: | | ||
<h2>Success! You did it! Hooray!</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry there is an error in YAML parsing starting on this line. YAML format is so strict! 😨
Each space is meaningful and necessary. Can you try to make the spacing consistent, for example on this line:
<h2>Success! You did it! Hooray!</h2> | |
<h2>Success! You did it! Hooray!</h2> |
See how each indent should be 2 spaces?
thank_you_for_contribution: | | ||
<h2>Success! You did it! Hooray!</h2> | ||
<hr> | ||
<p>Thank you so much for contributing open research and being part of our community.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line will also need an extra space.
config/locales/en.yml
Outdated
and thanks for your patience while your post is approved by <a href='/wiki/moderation'>community | ||
moderators</a> and we'll email you when it is published. In the meantime, if | ||
you have more to contribute, feel free to do so." | ||
thank_you_for_contribution: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think that there may need to be only one space before the |
character here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should i replace the lines in red with the lines in green or should i just fix the spacing
Code Climate has analyzed commit 77fa731 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for replying late i was a little busy with school project i have updated the spacing and made it consistent please feel free to correct me if there is any more mistake as i would correct it as soon as possible
Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add |
Improve text for welcome contribution notice
config/locales/en.yml
Fixes #0000
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below