Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix map css #11606

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

itsgurmannatsohal
Copy link

Fixes the map that hovers over footer

UI Fix

Fixes #10306

@welcome
Copy link

welcome bot commented Jan 24, 2023

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/10563985669/artifacts/525699537

.leaflet-pane{
position: initial !important;
}
.leaflet-bar, .leaflet-top{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @itsgurmannatsohal 💯
Maybe you could add the new property of leaflet-top to line 17, and have the remaining three "positions" on one line since they are similar. What do think?
Thanks for working on this @itsgurmannatsohal ❤️

Copy link
Author

@itsgurmannatsohal itsgurmannatsohal Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I was late. I was caught up in another work. I have made the changes, could you please review?
Thank you.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries at all @itsgurmannatsohal , the css file is looking good. Though it looks like the last commit on plots2-main was added on your recent commit - maybe a prob with the rebase?(files changed are now 3). Its no biggie as its the same as we have on main, but it would be cleaner to have only the changes you did on the issue. You could try removing them, but if it becomes a challenge just ping me and I am okay to merge it as is. Thanks again for working on this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that is because I synced the plots2/main with my fork. I did that

  1. To avoid any merge conflicts
  2. Because the tests were failing when I didn't sync (so I synced and squashed the last two commits).

I can revert them if you'd prefer that.

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/10741247654/artifacts/538855283

@github-actions
Copy link

github-actions bot commented Feb 2, 2023

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/10741546038/artifacts/538879092

improve-text-for-contributors (publiclab#11532)

* improve-text-for-contributors

* update

* Update en.yml

fix indentation

* fix indentation

* Update en.yml

* Update en.yml

* Update notes_controller_test.rb

* Update notes_controller_test.rb

* use line breaks inline

---------

Co-authored-by: Ogunbanjo oluwadamilare <[email protected]>
Co-authored-by: Cess <[email protected]>
Co-authored-by: Tilda Udufo <[email protected]>

review fixes
@codeclimate
Copy link

codeclimate bot commented Feb 3, 2023

Code Climate has analyzed commit ee39a55 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/10751623131/artifacts/539597153

Copy link

stale bot commented Apr 22, 2024

Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add in-progress label 🎉 . Otherwise, it will be closed if no further activity occurs in 10 days -- but you can always re-open it if you like! 💯 Thank you for your contributions! 🙌 🎈.

@stale stale bot added the stale label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map floats over footer while scrolling! - UI Bug (1/3)
2 participants