Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log file breaks production builds #8

Open
technosophos opened this issue Jul 17, 2014 · 3 comments
Open

Log file breaks production builds #8

technosophos opened this issue Jul 17, 2014 · 3 comments

Comments

@technosophos
Copy link
Contributor

Commit 399e5d1 is breaking our builds because it requires the process to have write access to the directory where the binary is executed (which in our case is an init script).

Could you either use the built-in log package (or log/syslog) or make the path to the log file configurable so we can put it in /var/log?

@crimsonred
Copy link
Contributor

@technosophos , you can disable logging by setting messaging.SetLogging(false) or configure the path of the log file in pubnub.go, (by setting the value of logfileName https://github.com/pubnub/go/blob/master/messaging/pubnub.go#L94). As of now logfileName is not exposed.

Please do let us know if either approach resolves the issue.

@technosophos
Copy link
Contributor Author

For now, we'll just set logging to false.

I like the way that Go's core "net/http".Server.ErrorLog works. I'd hope that that is the sort of model you move toward in the future.

@crimsonred
Copy link
Contributor

@technosophos , thanks for the suggestion. We will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants