fix: issue of parsing response for here_now #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parfeon
reviewed
Jan 2, 2025
Comment on lines
31
to
42
| // describe('#whereNow', () => { | ||
| // it('returns the requested data for user UUID', (done) => { | ||
| // const scope = utils | ||
| // .createNock() | ||
| // .get('/v2/presence/sub-key/mySubscribeKey/uuid/myUUID') | ||
| // .query({ | ||
| // pnsdk: `PubNub-JS-Nodejs/${pubnub.getVersion()}`, | ||
| // uuid: 'myUUID', | ||
| // }) | ||
| // .reply(200, '{"status": 200, "message": "OK", "payload": {"channels": ["a","b"]}, "service": "Presence"}', { | ||
| // 'content-type': 'text/javascript', | ||
| // }); |
There was a problem hiding this comment.
my bad! Reverting in a second
added 2 commits
January 2, 2025 16:26
This reverts commit 1ac00af. reverted last commit
mohitpubnub
added
type: bug
|
@parfeon Ready now for review |
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
kazydek and
techwritermat
as code owners
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: fix hereNow response parsing for total occupancy count field.
Fixed issue of hereNow response parsing for
totalOccupancyfield.