Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] Fix method sendEvent for event types different from custom #171

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[JS] Fix method sendEvent for event types different from custom #171

wants to merge 3 commits into from

Conversation

marcin-cebo
Copy link
Contributor

No description provided.

wkal-pubnub
wkal-pubnub requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@wkal-pubnub wkal-pubnub left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave only the added tests from this PR, delete everything else and change in ChatJs.emitEvent:

...
            payload.type = type
            - PNDataEncoder.decode(createJsonElement(payload))
            + PNDataEncoder.decode<EventContent>(createJsonElement(payload))
        }

@marcin-cebo
Copy link
Contributor Author

leave only the added tests from this PR, delete everything else and change in ChatJs.emitEvent:

...
            payload.type = type
            - PNDataEncoder.decode(createJsonElement(payload))
            + PNDataEncoder.decode<EventContent>(createJsonElement(payload))
        }

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkal-pubnub wkal-pubnub wkal-pubnub requested changes

@jguz-pubnub jguz-pubnub jguz-pubnub approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcin-cebo @jguz-pubnub @wkal-pubnub