PubNub SDK v4.5.2 release.

Author: client-engineering-bot

.pubnub.yml

@@ -1,8 +1,14 @@
 name: python
-version: 4.5.1
+version: 4.5.2
 schema: 1
 scm: github.com/pubnub/python
 changelog:
+  - version: v4.5.2
+    date: May 29, 2020
+    changes:
+      -
+        text: "Fix bug with max message count parameter for Fetch Messages endpoint. Rename maximum_per_channel parameter to count for Fetch Messages, keeping the old name for compatibility."
+        type: bug
   - version: v4.5.1
     date: May 4, 2020
     changes:

CHANGELOG.md

@@ -1,6 +1,10 @@
-## [v4.5.1](https://github.com/pubnub/python/releases/tag/v4.5.1)
+## [v4.5.2](https://github.com/pubnub/python/releases/tag/v4.5.2)
+
+[Full Changelog](https://github.com/pubnub/python/compare/v4.5.1...v4.5.2)
 
-[Full Changelog](https://github.com/pubnub/python/compare/v4.5.0...v4.5.1)
+- 🐛 Fix bug with max message count parameter for Fetch Messages endpoint. Rename maximum_per_channel parameter to count for Fetch Messages, keeping the old name for compatibility. 
+
+## [v4.5.1](https://github.com/pubnub/python/releases/tag/v4.5.1)
 
 - 🐛 Using SSL by default from the Python SDK to be more consistent and encourage best practices. 
 

pubnub/endpoints/fetch_messages.py

@@ -16,7 +16,7 @@ class FetchMessages(Endpoint):
     FETCH_MESSAGES_PATH = "/v3/history/sub-key/%s/channel/%s"
     FETCH_MESSAGES_WITH_ACTIONS_PATH = "/v3/history-with-actions/sub-key/%s/channel/%s"
 
-    DEFAULT_MESSAGES = 100
+    DEFAULT_MESSAGES = 25
     MAX_MESSAGES = 25
     MAX_MESSAGES_ACTIONS = 100
 
@@ -25,19 +25,22 @@ def __init__(self, pubnub):
         self._channels = []
         self._start = None
         self._end = None
-        self._maximum_per_channel = None
+        self._count = None
         self._include_meta = None
         self._include_message_actions = None
 
     def channels(self, channels):
         utils.extend_list(self._channels, channels)
         return self
 
-    def maximum_per_channel(self, maximum_per_channel):
-        assert isinstance(maximum_per_channel, six.integer_types)
-        self._maximum_per_channel = maximum_per_channel
+    def count(self, count):
+        assert isinstance(count, six.integer_types)
+        self._count = count
         return self
 
+    def maximum_per_channel(self, maximum_per_channel):
+        return self.count(maximum_per_channel)
+
     def start(self, start):
         assert isinstance(start, six.integer_types)
         self._start = start
@@ -59,7 +62,7 @@ def include_message_actions(self, include_message_actions):
         return self
 
     def custom_params(self):
-        params = {'max': str(self._maximum_per_channel)}
+        params = {'max': int(self._count)}
 
         if self._start is not None:
             params['start'] = str(self._start)
@@ -103,20 +106,20 @@ def validate_params(self):
             self._include_message_actions = False
 
         if self._include_message_actions is False:
-            if self._maximum_per_channel is None or self._maximum_per_channel < FetchMessages.DEFAULT_MESSAGES:
-                self._maximum_per_channel = FetchMessages.DEFAULT_MESSAGES
-                logger.info("maximum_per_channel param defaulting to %d", FetchMessages.DEFAULT_MESSAGES)
-            elif self._maximum_per_channel > FetchMessages.MAX_MESSAGES:
-                self._maximum_per_channel = FetchMessages.MAX_MESSAGES
-                logger.info("maximum_per_channel param defaulting to %d", FetchMessages.DEFAULT_MESSAGES)
+            if self._count is None or self._count < 1:
+                self._count = FetchMessages.DEFAULT_MESSAGES
+                logger.info("count param defaulting to %d", FetchMessages.DEFAULT_MESSAGES)
+            elif self._count > FetchMessages.MAX_MESSAGES:
+                self._count = FetchMessages.MAX_MESSAGES
+                logger.info("count param defaulting to %d", FetchMessages.MAX_MESSAGES)
         else:
             if len(self._channels) > 1:
                 raise PubNubException(pn_error=PNERR_HISTORY_MESSAGE_ACTIONS_MULTIPLE_CHANNELS)
 
-            if self._maximum_per_channel is None or self._maximum_per_channel < 1 or\
-                    self._maximum_per_channel > FetchMessages.MAX_MESSAGES_ACTIONS:
-                self._maximum_per_channel = FetchMessages.MAX_MESSAGES_ACTIONS
-                logger.info("maximum_per_channel param defaulting to %d", FetchMessages.DEFAULT_MESSAGES)
+            if self._count is None or self._count < 1 or\
+                    self._count > FetchMessages.MAX_MESSAGES_ACTIONS:
+                self._count = FetchMessages.MAX_MESSAGES_ACTIONS
+                logger.info("count param defaulting to %d", FetchMessages.MAX_MESSAGES_ACTIONS)
 
     def create_response(self, envelope):  # pylint: disable=W0221
         return PNFetchMessagesResult.from_json(

pubnub/pubnub_core.py

@@ -56,7 +56,7 @@
 
 class PubNubCore:
     """A base class for PubNub Python API implementations"""
-    SDK_VERSION = "4.5.1"
+    SDK_VERSION = "4.5.2"
     SDK_NAME = "PubNub-Python"
 
     TIMESTAMP_DIVIDER = 1000

setup.py

@@ -2,7 +2,7 @@
 
 setup(
     name='pubnub',
-    version='4.5.1',
+    version='4.5.2',
     description='PubNub Real-time push service in the cloud',
     author='PubNub',
     author_email='[email protected]',