Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Security by Using Cryptographically Secure Random Numbers for IV Generation #191

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pubnub/crypto.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import json
import random
import logging

import os

from base64 import decodebytes, encodebytes, b64decode, b64encode
from Cryptodome.Cipher import AES
Expand Down Expand Up @@ -69,7 +69,7 @@ def extract_random_iv(self, message, use_random_iv):

def get_initialization_vector(self, use_random_iv):
if self.pubnub_configuration.use_random_initialization_vector or use_random_iv:
return "{0:016}".format(random.randint(0, 9999999999999999))
return os.urandom(16)
else:
return Initial16bytes

Expand Down