Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hideondefault change #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

hideondefault change #99

wants to merge 1 commit into from

Conversation

jorgecc
Copy link

@jorgecc jorgecc commented May 22, 2021

  • It adds a new feature to clean the canvas when the pencil is hidden. This feature is configurable.
  • It also adds a lot of cleanups and format of the code but nothing to change the functionality of the code.

@pubpub-zz
Copy link
Owner

Hi @jorgecc ,

Thanks for your contribution. I'm currently preparing to issue a new release and Actually I have lots of commits not published and merging will take some time. I will do this work immediately after(expected next week). I may ask you a little of help at that time.

@pubpub-zz
Copy link
Owner

Hi @jorgecc,
I'm reviewing your changes which take a little of time because I have lots of commits in advance not published yet (All my fault ... 🤐) but I like this refactoring.
I'm currently focusing on your real new feature. My understanding is that when you are going to pointer mode, all strokes are deleted. Is there other cases where you are expecting this behavior to occur? unless I missed something,using close/exit, the behavior is similar. What is the advantage you see of this option?

Thanks,

@pubpub-zz
Copy link
Owner

Hi @jorgecc,
Up 😃

1 similar comment
@pubpub-zz
Copy link
Owner

Hi @jorgecc,
Up 😃

@pubpub-zz
Copy link
Owner

Hi @jorgecc, can you review my comment above ?

@pubpub-zz
Copy link
Owner

Hi @jorgecc,
Can you review my comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants