Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Lexer to ES6 class #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheOpenDevProject
Copy link

As I was doing some work in an ES6 environment and needed to use this Lexer I decided to convert the Lexer to an ES6 Class.

Lexer can still be called using Lexer.lex(str,options) via a static method.

Some aditional work is required in terms of including the rest of the libraries removed by the require eg using Webpack.ProvidePlugin() although this extra step could be removed with more work.

@codecov-io
Copy link

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #82   +/-   ##
====================================
  Coverage      96%   96%           
====================================
  Files           1     1           
  Lines         675   675           
====================================
  Hits          648   648           
  Misses         27    27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 035c891...d401414. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants