Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we remove Orangelight::Stackmap concern? #4477

Closed
1 of 5 tasks
sandbergja opened this issue Oct 29, 2024 · 0 comments · Fixed by #4658
Closed
1 of 5 tasks

Can we remove Orangelight::Stackmap concern? #4477

sandbergja opened this issue Oct 29, 2024 · 0 comments · Fixed by #4658
Assignees
Labels
maintenance Ticket related to maintenance that needs to be done

Comments

@sandbergja
Copy link
Member

What maintenance needs to be done?

  • Check if we still need the code in the file app/controllers/concerns/orangelight/stackmap.rb
  • If we don't need it, delete it

Level of urgency

  • High
  • Moderate
  • Low

Why is this maintenance needed?

This doesn't appear to be called when opening the stackmaps modal. If it is no longer needed, we can simplify the code base a little!

@sandbergja sandbergja added the maintenance Ticket related to maintenance that needs to be done label Oct 29, 2024
@maxkadel maxkadel self-assigned this Dec 19, 2024
maxkadel added a commit that referenced this issue Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Ticket related to maintenance that needs to be done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants