Implement PR feedback

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,14 +1,14 @@
 ---
 name: Feature request
-about: Suggest an idea for Deeploy
+about: Suggest an idea for Chimera-SDK
 title: ''
 labels: enhancement
 assignees: ''
 
 ---
 
 ## Is your feature request related to a problem? Please describe.
-A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+A clear and concise description of what the problem is. Ex. The process to do X is very lengthy. By adding Y, we could make X be much faster.
 
 ## Describe the solution you'd like
 A clear and concise description of what you want to happen.

Makefile

@@ -11,11 +11,6 @@ help:
 	@echo ""
 	@echo "Available Targets:"
 	@echo " - format: Format all code"
-	@echo " - setup: Install dependencies"
-
-setup:
-	@echo "Installing dependencies..."
-	@pip install -r requirements.txt
 
 format:
 	@echo "Formatting code..."

README.md

@@ -19,10 +19,18 @@ The documentation for a specific branch can be accessed via `https://pulp-platfo
 ## Contributing
 ### Formatting
 To simplify formatting of the code, we provide a Makefiles target that runs clang-format on all source files.
-To install all required dependencies and run the formatter run:
+We recomment that you setup a virtual environment and install the required dependencies using the following commands:
+
+```bash
+python3 -m venv venv
+source venv/bin/activate
+pip install -r requirements.txt
+```
+Alternatively you can also use any mamba/conda environment.
+
+Then, to format the code, run the following command:
 
 ```bash
-make setup
 make format
 ```
 

tests/chimera-open/snitchCluster/simpleOffload/src_cluster/test_cluster.c

@@ -11,8 +11,6 @@
 
 #include "trampoline_snitchCluster.h"
 
-uint32_t *clintPointer = (uint32_t *)CLINT_CTRL_BASE;
-
 /**
  * @brief Interrupt handler for the cluster, which clears the interrupt flag for the current hart.
  *
@@ -26,18 +24,19 @@ __attribute__((naked)) void clusterInterruptHandler() {
         "csrr t0, mhartid\n"
         // Load the base address of clintPointer into t1
         // "lw t1, %0\n"
-        "lui t1, %%hi(clintPointer)\n"
-        "addi t1, t1, %%lo(clintPointer)\n"
+
+        // Load clint base address into t1
+        "la t1, __base_clint\n"
 
         // Calculate the interrupt target address: t1 = t1 + (t0 * 4)
         "slli t0, t0, 2\n"
         "add t1, t1, t0\n"
         // Store 0 to the interrupt target address
         "sw zero, 0(t1)\n"
         "ret"
-        :                   // No outputs
-        : "m"(clintPointer) // Pass clintPointer as input
-        : "t0", "t1"        // Declare clobbered registers
+        :            // No outputs
+        :            // No inputs
+        : "t0", "t1" // Declare clobbered registers
     );
 }