Skip to content

Commit

Permalink
CI: Report formatting issues in CI checks instead of PR reviews
Browse files Browse the repository at this point in the history
This reports verible formatting issues in CI checks instead of PR
discussions. It may be a question of personal taste, but I see two
advantages:
- Avoid inflated PR discussions (and mails that come with these).
- Allow automated formatting checks *before* opening a PR.

Signed-off-by: Nils Wistoff <[email protected]>
  • Loading branch information
niwis committed Mar 4, 2024
1 parent 6706bca commit 146f382
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions .github/workflows/verible.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@
# SPDX-License-Identifier: Apache-2.0

name: Verible
on:
pull_request_target:
on: [push, pull_request_target]

jobs:
format:
lint:
runs-on: ubuntu-latest
permissions:
checks: write
Expand All @@ -17,7 +16,11 @@ jobs:
- uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.sha }}
- uses: chipsalliance/verible-formatter-action@main
- uses: chipsalliance/verible-linter-action@main
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
files: 'core/**/*.{v,sv}'
paths: 'core/'
extensions: |
.sv
.v
reviewdog_reporter: github-check

0 comments on commit 146f382

Please sign in to comment.