Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poc - cookie auth #124

Closed
wants to merge 3 commits into from
Closed

poc - cookie auth #124

wants to merge 3 commits into from

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Oct 24, 2024

Rough draft, this will need a couple more steps to get there right, but:

  • changes UI_EXTERNAL_LOGIN_URI to /auth/login/
    • makes login button go the the right place
    • TODO missing link from our login form
    • TODO detect logged in vs not

open http://localhost:8002/auth/login/?next=%2Fui%2Flogin%2F

  • log in in the external login dialog
  • redirects to pulp ui login dialog
  • log in with username=HACK there
  • it will use cookie auth 🎉
20241024173944.mp4

(the rest of the PR is dealing with appContext.user logic, disabling fetch withCredentials:false which is needed for basic auth to work, and TODO loading user info)

@himdel himdel marked this pull request as draft October 24, 2024 18:02
@himdel himdel force-pushed the tmp branch 2 times, most recently from 9822859 to 941a273 Compare October 28, 2024 21:10
himdel added 3 commits October 28, 2024 22:06
@himdel
wip: allow session login
acba915 
use /auth/login/ for cookies
remove last AppContext.user, switch to UserContext.getUsername/isLoggedIn
@himdel
task detail - remove leading hr
ee4f7b2
@himdel
linters
6382747
@himdel
Copy link
Collaborator Author

himdel commented Dec 30, 2024 •
edited
Loading

Closing for #183,
other changes added to #191 #192

@himdel himdel closed this Dec 30, 2024
@himdel himdel mentioned this pull request Dec 30, 2024
Merged
himdel added a commit that referenced this pull request Dec 30, 2024
@himdel
Fixups from #124 (#192)
184f278 
* layout - pull out UserDropdown, DocsDropdown

* drop APPLICATION_NAME, UI_DOCS_URL

no need to have these overridable anymore

* inline AboutModal, dont condition on username
@himdel himdel deleted the tmp branch December 30, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@himdel