Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use optimize for rare edge cases #634

Open
quba42 opened this issue Aug 31, 2022 · 0 comments
Open

Use optimize for rare edge cases #634

quba42 opened this issue Aug 31, 2022 · 0 comments
Labels
.feature CHANGES/<issue_number>.feature

Comments

@quba42
Copy link
Collaborator

quba42 commented Aug 31, 2022

Consider the following situation.

  • The last version of some repository used mirror=False sync policy.
  • We now want to sync using mirror=True sync policy.
  • Since the mirror policy has changed a full sync will be done in case the change in sync policy results in a change that optimize would skip.
  • However, if no change materializes (the repo is already mirrored perfectly), then no new repo version is created, and the new sync policy is not saved on new_version.info.
  • If we now sync again using the exact same options as before, we will still do a full sync, even though we could optimize (if pulp_deb could remember that we already tried these sync options without affecting a change).

=> A missed opportunity for further optimization.
However, these circumstances strike me as pretty rare, so I am not sure if it is worth working on.

Note: There may be other similar situations with changed sync options that do not result in a new repo version other than just switching mirror policy.

@quba42 quba42 added .feature CHANGES/<issue_number>.feature and removed Triage-Needed labels Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.feature CHANGES/<issue_number>.feature
Projects
None yet
Development

No branches or pull requests

1 participant