Remove atom.trashItem and atom.showItemInFolder…

…since they weren't even being used. The equivalent functions from the `shell` module of `@electron/remote` have been performing the same task in PulsarNext for a while now.

Author: savetheclocktower

src/application-delegate.js

@@ -132,32 +132,6 @@ module.exports = class ApplicationDelegate {
     return ipcHelpers.on(ipcRenderer, 'did-leave-full-screen', callback);
   }
 
-  trashItem(filePath) {
-    // A simple wrapper around `shell.trashItem`, which currently can only be
-    // called from the main process on Windows.
-    return ipcRenderer.invoke('trashItem', filePath).then(({ outcome, error, result }) => {
-      if (outcome === 'success') {
-        // `result` is undefined, but we might as well guard against an
-        // Electron API change in the future.
-        return result;
-      } else if (outcome === 'failure') {
-        return Promise.reject(error);
-      }
-    });
-  }
-
-  showItemInFolder(filePath) {
-    // A simple wrapper around `shell.trashItem`, which currently can only be
-    // called from the main process.
-    return ipcRenderer.invoke('showItemInFolder', filePath).then(({ outcome, error, result }) => {
-      if (outcome === 'success') {
-        return result;
-      } else if (outcome === 'failure') {
-        return Promise.reject(error);
-      }
-    });
-  }
-
   async openWindowDevTools() {
     // Defer DevTools interaction to the next tick, because using them during
     // event handling causes some wrong input events to be triggered on

src/atom-environment.js

@@ -796,26 +796,6 @@ class AtomEnvironment {
     return this.setFullScreen(!this.isFullScreen());
   }
 
-  // A proxy to `shell.trashItem` — which ought to work in the renderer, but
-  // suffers from a bug on Windows. We work around it by delegating to the main
-  // process.
-  //
-  // Undocumented for now, but may eventually be an official part of the API
-  // for when community packages need to delete files.
-  trashItem(filePath) {
-    return this.applicationDelegate.trashItem(filePath);
-  }
-
-  // A proxy to `shell.showItemInFolder` — which ought to work in the renderer,
-  // but seems to suffer from a bug on macOS. We work around it by delegating
-  // to the main process.
-  //
-  // Undocumented for now, but may eventually be an official part of the API
-  // for when community packages need to perform this function.
-  showItemInFolder(filePath) {
-    return this.applicationDelegate.showItemInFolder(filePath);
-  }
-
   // Restore the window to its previous dimensions and show it.
   //
   // Restores the full screen and maximized state after the window has resized to

src/main-process/atom-application.js

@@ -136,41 +136,6 @@ ipcMain.handle('setAsDefaultProtocolClient', (_, { protocol, path, args }) => {
   return app.setAsDefaultProtocolClient(protocol, path, args);
 });
 
-// Handle file deletion requests.
-//
-// Works around https://github.com/electron/electron/issues/29598, which seems
-// to be the cause of failed deletion attempts on Windows.
-ipcMain.handle('trashItem', async (_, filePath) => {
-  // We can't toss a promise over the wall, so we'll `await` it on our side and
-  // report the progress back to the renderer.
-  //
-  // If we return an `Error` object from this handler in the case of error,
-  // `ipcRenderer.invoke` will detect it and wrap it with its own explanation.
-  // We want to preserve the original error and hide the implementation
-  // details, so we instead return an object with an explicit `outcome`
-  // property to avoid this behavior.
-  try {
-    // `shell.trashItem` resolves with an empty value on success…
-    let result = await shell.trashItem(filePath);
-    return { outcome: 'success', result };
-  } catch (error) {
-    // …and rejects on failure.
-    return { outcome: 'failure', error };
-  }
-});
-
-ipcMain.handle('showItemInFolder', async (_, filePath) => {
-  try {
-    // Result will be `undefined`, but might as well return it in case of a
-    // future Electron API change.
-    let result = shell.showItemInFolder(filePath);
-    return { outcome: 'success', result };
-  } catch (error) {
-    // Not sure whether this can even fail, but might as well handle it.
-    return { outcome: 'failure', error };
-  }
-})
-
 // The application's singleton class.
 //
 // It's the entry point into the Pulsar application and maintains the global state