Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Show in Explorer" from right clicked file explorer context menu, open Explorer on background #1088

Open
5 tasks done
LAGENCECREE opened this issue Sep 4, 2024 · 5 comments · May be fixed by #1167
Open
5 tasks done
Labels
bug Something isn't working

Comments

@LAGENCECREE
Copy link

Thanks in advance for your bug report!

  • Have you reproduced issue in safe mode?
  • Have you used the debugging guide to try to resolve the issue?
  • Have you checked our FAQs to make sure your question isn't answered there?
  • Have you checked to make sure your issue does not already exist?
  • Have you checked you are on the latest release of Pulsar?

What happened?

"Show in Explorer" from right clicked file explorer context menu,
open Explorer on the background of pulsar
(the system explorer window dont receive the focus or at least do not open over the pulsar window)

Pulsar version

1.118

Which OS does this happen on?

🪟 Windows

OS details

11

Which CPU architecture are you running this on?

None

What steps are needed to reproduce this?

On the file explorer panel,
Right-click a Folder
Click on "Show in explorer"

Additional Information:

I observed this bug too in the past , on windows 10 with atom editor

@LAGENCECREE LAGENCECREE added the bug Something isn't working label Sep 4, 2024
@confused-Techie
Copy link
Member

Thanks a ton for reporting this issue!

Looking into this, the way we currently open the file explorer occurs here.

Which essentially boils down to:

const shell = require('electron').shell;
shell.showItemInFolder(filePath);

Looking into it I can find some reports of the same behavior, such as here.

Which suggests that a solution would look like:

const shell = require('electron').remote.shell;
shell.showItemInFolder(filePath);

Although, I haven't done the testing or research to see if we would be able to do this.

@LAGENCECREE
Copy link
Author

LAGENCECREE commented Sep 5, 2024

thanks to you !
i guess i have to compile my own pulsar to test that,
i will try asap if i can (not sure)
or wait to be fixed by core devs in a future release 🙏

@LAGENCECREE
Copy link
Author

LAGENCECREE commented Sep 20, 2024

Hello

without the time to fix it on the core package
i created a custom package that fix it, at least on windows,

trought a "📂 Show with explorer+" entry
added on the right-click context menu of the explorer pane.

output

i'm open to publish on the community package list but i dont know how

@savetheclocktower
Copy link
Contributor

These directions are pretty thorough, though they probably need an update. You'll want to run ppm login to authenticate beforehand.

Make sure the package.json points to the correct GitHub repo and that you authenticate as the user that the repo is hosted on.

@confused-Techie
Copy link
Member

Taking a look at the reporters GitHub I don't see the package published. Which in this case may be fine, as I feel like this is absolutely something we would want to add to core, especially seeing as it's a pretty simple change. I'll try to draft up something soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants