Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Intermoduleのメソッドで引数で受け取る配列をできるだけreadonlyにする #736

Open
laminne opened this issue Oct 1, 2024 · 0 comments
Labels
T: improvement Improvement of functions, etc.

Comments

@laminne
Copy link
Member

laminne commented Oct 1, 2024

async fetchAccounts(
    id: AccountID[],
  ): Promise<Result.Result<Error, Account[]>> {
    return await this.fetchService.fetchManyAccountsByID(id);
  }

配列を受け取る部分を

async fetchAccounts(
    id: readonly AccountID[],
  ): Promise<Result.Result<Error, Account[]>> {
    return await this.fetchService.fetchManyAccountsByID(id);
  }

readonlyな配列を受け取るように変える

@laminne laminne added the T: improvement Improvement of functions, etc. label Oct 1, 2024
@laminne laminne changed the title fix: Intermoduleのメソッドで配列をできるだけreadonlyにする fix: Intermoduleのメソッドで引数で受け取る配列をできるだけreadonlyにする Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: improvement Improvement of functions, etc.
Projects
Status: Todo
Development

No branches or pull requests

1 participant