Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated SDK generation @ aws-cloudformation-user-guide 19dc52cd3f2007d6d268b65b739ffb5ebf8c1e76 #1939

Merged
merged 5 commits into from
Dec 27, 2024

Conversation

pulumi-bot
Copy link
Contributor

@pulumi-bot pulumi-bot commented Dec 27, 2024

Automated SDK generation @ aws-cloudformation-user-guide 19dc52cd3f2007d6d268b65b739ffb5ebf8c1e76

New resources:

  • appconfig.Deployment

New functions:

  • appconfig.getDeployment

Notes: unfortunately newly introduced AnycastIpList does not yet work as expected and is excluded; this is tracked in #1946

Copy link
Contributor

github-actions bot commented Dec 27, 2024

Does the PR have any schema changes?

Found 79 breaking changes:

Resources

  • 🟢 "aws-native:bedrock:KnowledgeBase": required: "storageConfiguration" property is no longer Required
  • 🟢 "aws-native:qbusiness:DataAccessor": required inputs: "applicationId" input has changed to Required
  • 🟢 "aws-native:rds:DbInstance": required: "dbSystemId" property is no longer Required

Types

  • 🟢 "aws-native:bedrock:KnowledgeBaseConfiguration": required: "vectorKnowledgeBaseConfiguration" property is no longer Required
  • 🟡 "aws-native:quicksight:DashboardPublishOptions": properties: "visualMenuOption" type changed from "#/types/aws-native:quicksight:DashboardVisualMenuOption" to "pulumi.json#/Any"
  • 🔴 "aws-native:quicksight:DashboardVisualMenuOption" missing
  • 🔴 "aws-native:quicksight:DataSetFileFormat" missing
  • 🟡 "aws-native:quicksight:DataSetS3Source": properties: "uploadSettings" type changed from "#/types/aws-native:quicksight:DataSetUploadSettings" to "pulumi.json#/Any"
  • 🔴 "aws-native:quicksight:DataSetTextQualifier" missing
  • 🔴 "aws-native:quicksight:DataSetUploadSettings" missing
  • "aws-native:quicksight:TemplateAxisDisplayOptions": properties:
    • 🟡 "axisLineVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
    • 🟡 "gridLineVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • "aws-native:quicksight:TemplateBoxPlotOptions": properties:
    • 🟡 "allDataPointsVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
    • 🟡 "outlierVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • "aws-native:quicksight:TemplateChartAxisLabelOptions": properties:
    • 🟡 "sortIconVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
    • 🟡 "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateColumnTooltipItem": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • "aws-native:quicksight:TemplateDataLabelOptions": properties:
    • 🟡 "categoryLabelVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
    • 🟡 "measureLabelVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
    • 🟡 "totalsVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
    • 🟡 "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateDataPathLabelType": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateDateAxisOptions": properties: "missingDateVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateDonutCenterOptions": properties: "labelVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateFieldBasedTooltip": properties: "aggregationVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateFieldLabelType": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateFieldTooltipItem": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateFreeFormLayoutElement": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateFreeFormLayoutElementBackgroundStyle": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateFreeFormLayoutElementBorderStyle": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • "aws-native:quicksight:TemplateFunnelChartDataLabelOptions": properties:
    • 🟡 "categoryLabelVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
    • 🟡 "measureLabelVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
    • 🟡 "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • "aws-native:quicksight:TemplateKpiSparklineOptions": properties:
    • 🟡 "tooltipVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
    • 🟡 "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateLabelOptions": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateLegendOptions": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateLineChartLineStyleSettings": properties: "lineVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateLineChartMarkerStyleSettings": properties: "markerVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateListControlSearchOptions": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateListControlSelectAllOptions": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateLoadingAnimation": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateMaximumLabelType": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateMinimumLabelType": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • "aws-native:quicksight:TemplatePanelConfiguration": properties:
    • 🟡 "backgroundVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
    • 🟡 "borderVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
    • 🟡 "gutterVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplatePanelTitleOptions": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplatePivotTableFieldOption": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • "aws-native:quicksight:TemplatePivotTableOptions": properties:
    • 🟡 "collapsedRowDimensionsVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
    • 🟡 "columnNamesVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
    • 🟡 "singleMetricVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
    • 🟡 "toggleButtonsVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • "aws-native:quicksight:TemplatePivotTablePaginatedReportOptions": properties:
    • 🟡 "overflowColumnHeaderVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
    • 🟡 "verticalOverflowVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplatePivotTableRowsLabelOptions": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplatePivotTotalOptions": properties: "totalsVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateProgressBarOptions": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateRadarChartAreaStyleSettings": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateRadarChartConfiguration": properties: "alternateBandColorsVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateRangeEndsLabelType": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateScrollBarOptions": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateSecondaryValueOptions": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateSheetControlInfoIconLabelOptions": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateSheetElementConfigurationOverrides": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateSheetImageTooltipConfiguration": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateSubtotalOptions": properties: "totalsVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateTableCellStyle": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateTableFieldOption": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • "aws-native:quicksight:TemplateTablePaginatedReportOptions": properties:
    • 🟡 "overflowColumnHeaderVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
    • 🟡 "verticalOverflowVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateTextControlPlaceholderOptions": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateThousandSeparatorOptions": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateTooltipOptions": properties: "tooltipVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateTotalOptions": properties: "totalsVisibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateTrendArrowOptions": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🔴 "aws-native:quicksight:TemplateVisibility" missing
  • 🟡 "aws-native:quicksight:TemplateVisualSubtitleLabelOptions": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"
  • 🟡 "aws-native:quicksight:TemplateVisualTitleLabelOptions": properties: "visibility" type changed from "#/types/aws-native:quicksight:TemplateVisibility" to "pulumi.json#/Any"

New resources:

  • appconfig.Deployment

New functions:

  • appconfig.getDeployment

@t0yv0
Copy link
Member

t0yv0 commented Dec 27, 2024

Checking up on the test failure:

=== RUN   TestNoUnexpectedTagsShapes
    gen_tags_test.go:160:
        	Error Trace:	/home/runner/work/pulumi-aws-native/pulumi-aws-native/provider/pkg/schema/gen_tags_test.go:160
        	Error:      	Should be empty, but was map[aws-native:cloudfront:AnycastIpList:map[$ref:#/definitions/Tags description:A complex type that contains zero or more `Tag` elements.]]
        	Test:       	TestNoUnexpectedTagsShapes
        	Messages:   	reports/unexpectedTagsShapes.json should be empty, which means that we need to update getTagsStyle in gen_tags.go to cover new tags variations.
--- FAIL: TestNoUnexpectedTagsShapes (0.00s)

@t0yv0
Copy link
Member

t0yv0 commented Dec 27, 2024

I've opted to Exclude AWS::CloudFront::AnycastIpList as it does not seem to work in AWS CF or at least I am not finding a good test case to try it out. #1946

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 50.29%. Comparing base (09d081f) to head (424dc15).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...ovider/cmd/pulumi-gen-aws-native/excluded_types.go 0.00% 5 Missing ⚠️
provider/cmd/pulumi-gen-aws-native/main.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1939      +/-   ##
==========================================
- Coverage   50.35%   50.29%   -0.06%     
==========================================
  Files          48       49       +1     
  Lines        7000     7008       +8     
==========================================
  Hits         3525     3525              
- Misses       3226     3234       +8     
  Partials      249      249              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t0yv0 t0yv0 merged commit db60834 into master Dec 27, 2024
18 checks passed
@t0yv0 t0yv0 deleted the generate-sdk/12511882021-939 branch December 27, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants