Update classic vpc nat gateway to use domain: "vpc" instead of deprecated vpc: true
#1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
eigilsagafos
changed the title
domain: "vpc" instead of deprecated vpc: truedomain: "vpc" instead of deprecated vpc: true
|
This looks good, thank you @eigilsagafos ! It seems to address a deprecation. Let me try to run tests here. |
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
|
@t0yv0 I updated based on the failing lint test. Could you trigger the tests again? |
|
/run-acceptance-tests |
|
Let's try it. Thank you! |
|
Please view the PR build - https://github.com/pulumi/pulumi-awsx/actions/runs/8637623550 |
t0yv0
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.