testing: examples/ecs/nodejs add missing dependsOn #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulumi was not recognizing that the underlying aws.ecs.Service should wait for the load balancer to be provisioned, causing a race that sporadically would flake up the test. This is now compensated by with a dependsOn option. Fixes #1418
|
#1442 marking another test as a flaky test. |
corymhall
approved these changes
Dec 17, 2024
| @@ -29,6 +29,8 @@ const service = new ecs.FargateService("my-service", { | |||
| subnets: vpc.publicSubnetIds, | |||
| assignPublicIp: true, | |||
| }, | |||
| }, { | |||
| dependsOn: [lb.loadBalancer], | |||
There was a problem hiding this comment.
Should we add logic to the FargateService component to automatically add the dependency on the load balancer?
There was a problem hiding this comment.
Based on our conversation I think we concluded given the component is under the classic portion of the provider our preference would be to sanitize examples instead to not rely on those components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulumi was not recognizing that the underlying aws.ecs.Service should wait for the load balancer to be provisioned, causing a race that sporadically would flake up the test. This is now compensated by with a dependsOn option.
Fixes #1418