Increase default runner to pulumi-ubuntu-8core #1385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
approved these changes
Oct 12, 2023
Comment on lines
32
to
34
| prerequisites: pulumi-ubuntu-8core | ||
| buildSdk: pulumi-ubuntu-8core | ||
| publish: pulumi-ubuntu-8core |
There was a problem hiding this comment.
Nit: We can comment these out if we want, since they are overriding the default and the same as the default.
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
guineveresaenger
requested changes
Oct 16, 2023
There was a problem hiding this comment.
I think most of these aren't really necessary.
Most of these were addressed via logic in the ci-mgmt templates (the templates decide which runner to assign based on the config field set), and passed to pulumi-azure's Workflows via PRs like this one.
See also changes applied here.
I think we can close this out.
|
@rquitales Can we close this? |
|
Stale PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help unblock all CI jobs.