Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeouts silently ignored #184

Open
flostadler opened this issue Aug 22, 2024 · 1 comment
Open

timeouts silently ignored #184

flostadler opened this issue Aug 22, 2024 · 1 comment
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@flostadler
Copy link

What happened?

When trying to convert a resource with timeouts, those get silently dropped. This seems expected given this comment here:

// Timeouts are a special resource option block, we can't currently convert that PCL so just skip

This seems to cause: pulumi/pulumi-aws#4391

I found this similar existing issue #104, but the difference here is that we're not getting an error.

Example

resource "aws_security_group" "example" {
  name = "izizavle"

  timeouts {
    delete = "2m"
  }
}

Output of pulumi about

n/a

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@flostadler flostadler added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Aug 22, 2024
@justinvp justinvp removed the needs-triage Needs attention from the triage team label Aug 22, 2024
@justinvp
Copy link
Member

justinvp commented Oct 2, 2024

I believe we need to add support for timeouts to PCL and update programgen to be able to emit it. Then we can make the converter set it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

2 participants