Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable tests that cause failures due to using too many system resources #21

Open
justinvp opened this issue Aug 21, 2023 · 2 comments · May be fixed by #26
Open

Re-enable tests that cause failures due to using too many system resources #21

justinvp opened this issue Aug 21, 2023 · 2 comments · May be fixed by #26
Labels
kind/engineering Work that is not visible to an external user

Comments

@justinvp
Copy link
Member

justinvp commented Aug 21, 2023 •
edited
Loading

There are currently a set of tests that are skipped because they fail in CI. It looks like the tests use too many system resources, resulting in a crash.

This may be a legitimate bug that we need to work around in either the converter or programgen. Investigate why we're using so many resources and see if we can reduce.
@justinvp justinvp added the kind/engineering Work that is not visible to an external user label Aug 21, 2023
@lukehoban
Copy link

If there isn’t an immediate implementation bug fix here - should we move to larger runners in the meantime to ensure we lock in test coverage?

@justinvp
Copy link
Member Author

Good idea. I’ll give it a try.

@justinvp justinvp linked a pull request Sep 4, 2023 that will close this issue
Draft
@brandonpollack23 brandonpollack23 mentioned this issue Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run tests on a larger runner pulumi/pulumi-converter-terraform
2 participants
@lukehoban @justinvp