Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New build-id label results in unique digests on each build #1219

Closed
lionello opened this issue Sep 3, 2024 · 2 comments · Fixed by #1225
Closed

New build-id label results in unique digests on each build #1219

lionello opened this issue Sep 3, 2024 · 2 comments · Fixed by #1225
Assignees
@blampe
Labels
impact/regression Something that used to work, but is now broken kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Milestone
0.110

Comments

@lionello
Copy link

lionello commented Sep 3, 2024 •
edited
Loading

In #843 a random build-id label was added to the image, resulting in a unique digest for each build. This in turn results in our service getting restarted (because the image "changed") even though the actually build context was identical.

PR #843 caused a regression in #32 because the random build-id appears to cause the image to change each time I run pulumi up.

Issue #846 was filed to remove the build-id but this issue is still open with no activity for a while.
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Sep 3, 2024
@blampe
Copy link
Contributor

blampe commented Sep 5, 2024

Hi @lionello, thanks for raising this. I'll look into removing the random ID. In the mean time you might have luck with the new docker-build provider.

@blampe blampe removed the needs-triage Needs attention from the triage team label Sep 5, 2024
@blampe blampe mentioned this issue Sep 5, 2024
Merged
@mikhailshilkov mikhailshilkov added p1 A bug severe enough to be the next item assigned to an engineer kind/bug Some behavior is incorrect or out of spec impact/regression Something that used to work, but is now broken labels Sep 9, 2024
@mikhailshilkov mikhailshilkov added this to the 0.110 milestone Sep 16, 2024
@blampe blampe closed this as completed in 96b658d Sep 19, 2024
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Sep 19, 2024
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #1225 and shipped in release v4.5.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blampe blampe

Labels
impact/regression Something that used to work, but is now broken kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.110
Development

Successfully merging a pull request may close this issue.

Remove random build ID pulumi/pulumi-docker
4 participants
@lionello @blampe @mikhailshilkov @pulumi-bot