Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SSH setup action #1300

Merged
merged 8 commits into from
Dec 9, 2024
Merged

Remove SSH setup action #1300

merged 8 commits into from
Dec 9, 2024

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Dec 7, 2024

This removes our custom SSH setup action in favor of some logic within the test that needs it.

Copy link

github-actions bot commented Dec 7, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Putting the SSH setup in the test is much cleaner than via CI as it allows us to run this locally too 🎉

Happy for the CI option to go now too.

@blampe blampe merged commit d983eca into master Dec 9, 2024
23 checks passed
@blampe blampe deleted the blampe/ssh-agent branch December 9, 2024 15:55
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v4.5.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants