Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestDebuggerAttachDotnet is flaky #403

Open
Frassle opened this issue Nov 21, 2024 · 1 comment
Open

TestDebuggerAttachDotnet is flaky #403

Frassle opened this issue Nov 21, 2024 · 1 comment
Assignees
@justinvp
Labels
impact/flaky-test A test that is unreliable kind/engineering Work that is not visible to an external user

Comments

@Frassle
Copy link
Member

Frassle commented Nov 21, 2024

What happened?

This test keeps timing out but seemingly only on macos-12.

Example

https://github.com/pulumi/pulumi-dotnet/actions/runs/11956317375/job/33330781813?pr=400

Output of pulumi about

N/A

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@Frassle Frassle added impact/flaky-test A test that is unreliable kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer labels Nov 21, 2024
@justinvp justinvp added kind/engineering Work that is not visible to an external user and removed p1 A bug severe enough to be the next item assigned to an engineer kind/bug Some behavior is incorrect or out of spec labels Nov 25, 2024
@justinvp justinvp self-assigned this Dec 3, 2024
@justinvp justinvp changed the title TestDebuggerAttachDotnet is flaky on macos-12 TestDebuggerAttachDotnet is flaky Dec 9, 2024
@justinvp
Copy link
Member

justinvp commented Dec 9, 2024

Also hit it on macos-13: https://github.com/pulumi/pulumi-dotnet/actions/runs/12207877427/job/34060079149#step:12:252

There are similar failures on Windows, but not clear if it's related to TestDebuggerAttachDotnet or some other flake.

This was referenced Dec 9, 2024
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 9, 2024
@justinvp
Temporarily skip flaky TestDebuggerAttachDotnet test (#425)
fdb0b9c 
We're still seeing this test fail on macOS and it looks like it may be
affecting Windows as well. Temporarily skip it for now.

Going to see if skipping also removes the flakes on Windows.

#403 tracks fixing the test for real / unskipping.

Fixes #419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinvp justinvp

Labels
impact/flaky-test A test that is unreliable kind/engineering Work that is not visible to an external user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justinvp @Frassle