Add clusterIdentifier configuration to control provider lifecycle
#3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3068 +/- ##
==========================================
- Coverage 36.58% 36.57% -0.02%
==========================================
Files 71 71
Lines 9263 9275 +12
==========================================
+ Hits 3389 3392 +3
- Misses 5535 5543 +8
- Partials 339 340 +1 ☔ View full report in Codecov by Sentry. |
EronWright
reviewed
Jun 26, 2024
There was a problem hiding this comment.
Looks good to me, have 2 points:
- there's already some tests for DiffConfig in
provider_diffconfig_test.go; can we add a section to outline the behavior of the clusteridentifer? - The term
clusterIdentifierseems a bit long and imprecise, I would advocate forclusterKey.
EronWright
approved these changes
Jul 17, 2024
rquitales
approved these changes
Jul 17, 2024
…mpe/2745-clusterid
blampe
added a commit
that referenced
this pull request
Aug 7, 2024
### Added - `clusterIdentifier` configuration can now be used to manually control the replacement behavior of a provider resource. (#3068) - Pod errors now include the pod's last termination state, as well as the pod's termination message if available. (#3091) The pod's termination message can be helpful in `CrashLoopBackOff` situations but will only be reported if it was correctly configured. By default, the pod's termination message is read from `/dev/termination-log`. This location can be configured with `terminationMessagePath`. Use `terminationMessagePolicy: FallbackToLogsOnError` to use the pod's logs as its termination message. - Documentation is now generated for all languages supported by overlay types. (#3107) ### Fixed - Updated logic to accurately detect if a resource is a Patch variant. (#3102) - Added Java as a supported language for `CustomResource` overlays. (#3120) - Status messages reported during updates are now more accurately scoped to the affected resource. (#3128) - `PersistentVolumeClaims` with a bind mode of `WaitForFirstConsumer` will no longer hang indefinitely. (#3130) - [java] Fixed an issue where child resources could not be registered by Chart v4. (#3119)
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
Aug 8, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/kubernetes](https://pulumi.com) ([source](https://togithub.com/pulumi/pulumi-kubernetes)) | dependencies | minor | [`4.15.0` -> `4.16.0`](https://renovatebot.com/diffs/npm/@pulumi%2fkubernetes/4.15.0/4.16.0) | --- ### Release Notes <details> <summary>pulumi/pulumi-kubernetes (@​pulumi/kubernetes)</summary> ### [`v4.16.0`](https://togithub.com/pulumi/pulumi-kubernetes/blob/HEAD/CHANGELOG.md#4160-August-7-2024) [Compare Source](https://togithub.com/pulumi/pulumi-kubernetes/compare/v4.15.0...v4.16.0) ##### Added - `clusterIdentifier` configuration can now be used to manually control the replacement behavior of a provider resourc[https://github.com/pulumi/pulumi-kubernetes/pull/3068](https://togithub.com/pulumi/pulumi-kubernetes/pull/3068)ull/3068) - Pod errors now include the pod's last termination state, as well as the pod's termination message if availabl[https://github.com/pulumi/pulumi-kubernetes/pull/3091](https://togithub.com/pulumi/pulumi-kubernetes/pull/3091)ull/3091) The pod's termination message can be helpful in `CrashLoopBackOff` situations but will only be reported if it was correctly configured. By default, the pod's termination message is read from `/dev/termination-log`. This location can be configured with `terminationMessagePath`. Use `terminationMessagePolicy: FallbackToLogsOnError` to use the pod's logs as its termination message. - Documentation is now generated for all languages supported by overlay types. [https://github.com/pulumi/pulumi-kubernetes/pull/3107](https://togithub.com/pulumi/pulumi-kubernetes/pull/3107)3107) ##### Fixed - Updated logic to accurately detect if a resource is a Patch variant. ([https://github.com/pulumi/pulumi-kubernetes/pull/3102](https://togithub.com/pulumi/pulumi-kubernetes/pull/3102)) - Added Java as a supported language for `CustomResource` overlays. ([https://github.com/pulumi/pulumi-kubernetes/pull/3120](https://togithub.com/pulumi/pulumi-kubernetes/pull/3120)) - Status messages reported during updates are now more accurately scoped to the affected resourc[https://github.com/pulumi/pulumi-kubernetes/pull/3128](https://togithub.com/pulumi/pulumi-kubernetes/pull/3128)3128) - `PersistentVolumeClaims` with a bind mode of `WaitForFirstConsumer` will no longer hang indefinitel[https://github.com/pulumi/pulumi-kubernetes/pull/3130](https://togithub.com/pulumi/pulumi-kubernetes/pull/3130)3130) - \[java] Fixed an issue where child resources could not be registered by Chart v4. [https://github.com/pulumi/pulumi-kubernetes/pull/3119](https://togithub.com/pulumi/pulumi-kubernetes/pull/3119)9) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMS4zIiwidXBkYXRlZEluVmVyIjoiMzguMjEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsidHlwZS9taW5vciJdfQ==--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
clusterIdentifierprovider configuration to control replacement behavior.If this config has been previously set, then we will only replace the provider when
clusterIdentifierchanges. Additionally, changes to other properties likekubeconfigwhich currently trigger replacements will now only be updates.An E2E test is included along with unit tests. The units use txtar to more conveniently express before/after state in YAML -- a sort of middle ground between massive table tests and full-blown integration tests.
Fixes #2745.