Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout experimental converter to Tier 1 providers #1413

Closed
4 tasks done
Tracked by #1280
t0yv0 opened this issue Oct 3, 2023 · 5 comments
Closed
4 tasks done
Tracked by #1280

Rollout experimental converter to Tier 1 providers #1413

t0yv0 opened this issue Oct 3, 2023 · 5 comments
Assignees
Labels
kind/epic Large new features or investments resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Milestone

Comments

@t0yv0
Copy link
Member

t0yv0 commented Oct 3, 2023

By provider:

Tier 1 Provider Upgrade Procedure:

Example output for pulumi-gcp:

Baseline     2328
Provider:     google-beta
Success rate: 95.16% (13144/13812)

Converted 93.96% of csharp examples (2163/2302)
Converted 93.92% of go examples (2162/2302)
Converted 97.87% of java examples (2253/2302)
Converted 93.96% of python examples (2163/2302)
Converted 93.96% of typescript examples (2163/2302)
Converted 97.31% of yaml examples (2240/2302)

Experimental 2328
Provider:     google-beta
Success rate: 99.69% (13464/13506)

Converted 99.78% of csharp examples (2246/2251)
Converted 99.73% of go examples (2245/2251)
Converted 99.60% of java examples (2242/2251)
Converted 99.78% of python examples (2246/2251)
Converted 99.78% of typescript examples (2246/2251)
Converted 99.47% of yaml examples (2239/2251)
@t0yv0 t0yv0 added this to the 0.95 milestone Oct 3, 2023
@t0yv0 t0yv0 added the size/S Estimated effort to complete (1-2 days). label Oct 3, 2023
@mikhailshilkov mikhailshilkov added the kind/epic Large new features or investments label Oct 4, 2023
@t0yv0
Copy link
Member Author

t0yv0 commented Oct 17, 2023

Merges blocked per conversation with the docs team. Reminder to look at it on 19th.

@t0yv0 t0yv0 self-assigned this Oct 17, 2023
@mikhailshilkov mikhailshilkov modified the milestones: 0.95, 0.96 Oct 26, 2023
@mikhailshilkov mikhailshilkov modified the milestones: 0.96, 0.97 Nov 23, 2023
@t0yv0
Copy link
Member Author

t0yv0 commented Dec 8, 2023

Waiting on pulumi/pulumi#14718

@t0yv0
Copy link
Member Author

t0yv0 commented Dec 15, 2023

A bit more progress here. We landed 14718 thanks to the platform team so the pipeline is now working in a stable fashion. However, further analysis of the Azure AD PR uncovered regressions in example quality:

pulumi/pulumi-yaml#539
pulumi/pulumi-converter-terraform#88

The YAML one is particularly egregious and I would consider a blocker again.

@lukehoban lukehoban modified the milestones: 0.97, 0.98 Dec 20, 2023
@lukehoban lukehoban modified the milestones: 0.98, 0.100 Feb 13, 2024
@t0yv0
Copy link
Member Author

t0yv0 commented Mar 1, 2024

Many thanks to @Frassle and @Zaid-Ajaj working through some build stability issues in the converter; this is now rolled out to the above providers.

@t0yv0 t0yv0 closed this as completed Mar 1, 2024
@pulumi-bot pulumi-bot reopened this Mar 1, 2024
@pulumi-bot
Copy link
Contributor

Cannot close issue:

  • does not have required labels: resolution/

Please fix these problems and try again.

@t0yv0 t0yv0 added the resolution/fixed This issue was fixed label Mar 1, 2024
@t0yv0 t0yv0 closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic Large new features or investments resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Projects
None yet
Development

No branches or pull requests

4 participants