Error getVoter() must be an instance of Thucke\ThRating\Domain\Model\Voter

[linawolf]

Bug Report

Prerequisites

• [x ] Can you reproduce the problem on TYPO3 v9.5 LTS
• Can you reproduce the problem on TYPO3 v10.4 LTS
• Did you perform a cursory search to see if your bug or feature is already reported?

Might be related to #68

Description

When calling my news item in which I included the rating template I get the following:

(1/1) TypeError
Return value of Thucke\ThRating\Domain\Model\Vote::getVoter() must be an instance of Thucke\ThRating\Domain\Model\Voter, null returned

in /var/www/html/private/typo3conf/ext/th_rating/Classes/Domain/Model/Vote.php line 169

Steps to Reproduce

1. Install Extension and include templates,
2. Create a rating object with 2 steps, table tx_news, field uid
3. include the following into the news template::

<f:format.raw>
<thr:rating ratetable="tx_news" ratefield="uid" ratedobjectuid="{newsItem.uid}" ></thr:rating>
</f:format.raw>

Expected behavior: news with voting displayed

**Actual behavior:**error message

Versions

typo3/cms-core v9.5.25
georgringer/news 8.5.2
thucke/th-rating 1.8.3

[thucke]

Hallo Frau Wolf, das ist interessant, danke für die Meldung. Können Sie mal prüfen, ob die Angaben für mapAnonymous und die anderen PID Einstellungen korrekt sind? Am Besten wäre, wenn ich die Möglichkeit hätte, selbst einen Blick ins Backend werfen zu können. Können Sie mir da einen Zugang einrichten? VG Thomas Hucke PS: Ich entwickle die Erweiterung privat neben meinem Vollzeitjob. Ich kann daher u.U. nicht so schnell agieren, wie Sie es vielleicht benötigen würden. Ich versuch aber mein Möglichstes Am 7. Juni 2021 15:01:40 MESZ schrieb Lina Wolf ***@***.***>:

…

# Bug Report ## Prerequisites * [x ] Can you reproduce the problem on TYPO3 v9.5 LTS * [ ] Can you reproduce the problem on TYPO3 v10.4 LTS * [ ] Did you [perform a cursory search](https://github.com/search?q=is%3Aissue+repo%3Athucke%2FTYPO3.ext.th_rating) to see if your bug or feature is already reported? Might be related to #68 ## Description When calling my news item in which I included the rating template I get the following: (1/1) TypeError Return value of Thucke\ThRating\Domain\Model\Vote::getVoter() must be an instance of Thucke\ThRating\Domain\Model\Voter, null returned in /var/www/html/private/typo3conf/ext/th_rating/Classes/Domain/Model/Vote.php line 169 ## Steps to Reproduce 1. Install Extension and include templates, 2. Create a rating object with 2 steps, table tx_news, field uid 3. include the following into the news template:: <f:format.raw> <thr:rating ratetable="tx_news" ratefield="uid" ratedobjectuid="{newsItem.uid}" ></thr:rating> </f:format.raw> **Expected behavior:** news with voting displayed **Actual behavior:**error message ## Versions typo3/cms-core v9.5.25 georgringer/news 8.5.2 thucke/th-rating 1.8.3 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #133

-- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

[linawolf]

Ich habe folgende Konstanten gesetzt:

plugin.tx_thrating.config.loadJQuery = 0
plugin.tx_thrating.settings.pluginStoragePid = 62

mapanonymos hatte ich nicht gesetzt. Ich habe es mit

plugin.tx_thrating.settings.mapAnonymous = 1

versucht, der Fehler bleibt bestehen

[linawolf]

I tried using the current master of this project instead and I get another error:

(1/1) #1476107295 TYPO3\CMS\Core\Error\Exception
PHP Warning: Use of undefined constant JSON_THROW_ON_ERROR - assumed 'JSON_THROW_ON_ERROR' (this will throw an Error in a future version of PHP) in /var/www/html/private/typo3conf/ext/th_rating/Classes/Service/JsonService.php line 35

[linawolf]

using master - and using PHP 7.4 to prevent the above error I can open the news page containing the viewhelper. I don't see any ratings yet which might be another problem though.

Unfortunate we only have PHP 7.2 available on the customer server...

[thucke]

First: Sorry for the german tongue in my prior message ;-)

Unfortunately support for PHP 7.2 has dropped with version 1.9 of the extension.

Anyway - it should work in your constellation using version 1.8.3.

Please check if the following is set correctly and points to the page where the webusers are stored:

plugin.tx_felogin_pi1.storagePid

[linawolf]

We don't have any fe users

[thucke]

Well, I'll try to conclude the current situation: - you wankt to have ratings for your news entries - you don't have fe users - you don't want to have anonymous ratings (which also at least requires one dummy fe user) If this summary is correct, I'm afraid Rating AX isn't the right extension for you use case. It requires either anonymous ratings or named rating from website users. Please tell me if I got something wrong. Greets Thomas Am 11. Juni 2021 07:37:12 MESZ schrieb Lina Wolf ***@***.***>:

…

We don't have any fe users -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #133 (comment)

-- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

[linawolf]

Seems like I missed this part: I do need an fe_user even if I want to have anonymos voting?

[thucke]

Yes, that's right.
But it's really only a dummy user because every vote requires a valid FE user.
There's no need that one should do a logon or something like that.
Because of that I'd suggest to set a maximum complex password (which could be forgotten immediately) for him.

I'll think about if I implement the automatic setup of such a user. It seems that replacing the current manual setup could make Rating AX a bit more comfortable to use.

[linawolf]

Ill have another look into it. I've been unwell this week due to my Covid Vaccine and the heat. So I have not been working on this