Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weapons plugin minor issues. #22

Open
gdfsgdfg opened this issue Mar 24, 2022 · 6 comments
Open

Weapons plugin minor issues. #22

gdfsgdfg opened this issue Mar 24, 2022 · 6 comments
Assignees
Labels
being worked on enhancement New feature or request

Comments

@gdfsgdfg
Copy link

gdfsgdfg commented Mar 24, 2022

Energy Orb effect doesn't apply on grenade launcher. I'm not sure if others have that bug. Also needs the community sparkle effect since its a real thing. And the firey flying bits one tho I think only Robin had that.

And also should add 2 more melee weapon overrides at least ones that are rare like the batsaber and memory maker.

Oh yeah and heavy's robo-sandvich can't forget about that one.

@punteroo
Copy link
Owner

The plugin performs attribute changes when an override is detected. Every weapon currently equipped in your inventory will be listed, if it's stock a conversion will be done to it's strange variant definition index (as the game doesn't allow these customization attributes on stock weapons).

Unusual effects set on weapons are hardcoded here. If you wish to add Community Sparkle and/or Flying Bits do so by adding 4 and 2 respectively to the array and list their names on the function that gives them such. Then re-compile.

I haven't added them in as they're not obtainable in vanilla but rather given out by VALVe Employees, however it is also a bad practice on my part to hard-code these IDs instead of offering customizability without a full re-compile of the entire project.
Will consider on modifying this method for the next release.

@punteroo punteroo added enhancement New feature or request being worked on labels Apr 11, 2022
@punteroo punteroo self-assigned this Apr 11, 2022
@punteroo
Copy link
Owner

Hello.

Please confirm the issues reported here are gone to properly close the Issue or handle it accordingly.

@gdfsgdfg
Copy link
Author

gdfsgdfg commented Aug 16, 2024

You've broken it even more for me and now I am unable to get the golden pan, saxxy or golden wrench. Rejoining the server did not save my settings on the minigun and banana. The unusual effect was applied only once on the minigun and I couldn't apply it again after rejoining.

Now it keeps saying I'm on cooldown and can't even get my saved preferences, it should always load your weapons when joining the server this feature seems pointless also with deleting the data.

@punteroo
Copy link
Owner

Golden Pan, Saxxy and Golden Wrench are no longer a functionality on the plugin packs as equipping weapons you do not own is not something planned for this initial rewrite release. These will be implemented on a later release with proper handling to prevent class-based issues, along with something similar for cosmetic items.

Saving/loading now works with SQLite databases, make sure you've set-up the database for your server entry correctly. If issues persist with cooldowns, I'll give it a check later.

@gdfsgdfg
Copy link
Author

gdfsgdfg commented Aug 16, 2024

Deleting the saved preference fixed the cooldown bug, I've changed the map and it seems to have remembered my settings without having to load them, however my real australium minigun is not getting replaced still, unequipped it and did active changes and it worked then so I guess its an issue with equipping your own weapon I guess.

More fiddling around and it does appear that now its replacing my aussie minigun and its saved between maps.

So if you fiddle enough it should remember the loadout I guess. Yes unusuals works fine as well.

I'll close this when you add those 3 melee weapons back as they were the main reason I used the plugin mostly for the golden pan but glad to see it can actually save your loadout now!

I've also learned that energy orb not working on grenade launcher is actually a game bug the more you know I guess.

@gdfsgdfg
Copy link
Author

gdfsgdfg commented Aug 16, 2024

More testing and it seems squash rockets / gourd grenades doesn't work but exorcism does and I'm also unable to modify any weapon on engineer.

Green Flames on pyro works as well.

Edit: The cosmetic plugin lets you put unusual taunt effects on hats which is not good to say the least probably should find a way to block effect ids from 3000 and up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
being worked on enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants