Merge pull request #921 from puppetlabs/fix_nightly_failure_npm_version

Fix nightly workflow failures: BUILD_VERSION context and Node.js compatibility

Author: LukasAud

.github/workflows/mend.yml

@@ -14,10 +14,10 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - name: 'setup node: 18 platform: ${{ runner.os }}'
+      - name: 'setup node: 20 platform: ${{ runner.os }}'
         uses: actions/setup-node@v4
         with:
-          node-version: 18
+          node-version: 20
 
       - name: npm install
         run: |

.github/workflows/nightly.yml

@@ -10,7 +10,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        node-version: [18]
+        node-version: [20]
         os: [ubuntu-latest, windows-latest, macos-latest]
 
     steps:
@@ -62,7 +62,7 @@ jobs:
 
       - name: npm test
         env:
-          BUILD_VERSION: '0.99.${{ github.event.number }}'
+          BUILD_VERSION: 0.99.${{ github.run_number }}
           VSCODE_BUILD_VERBOSE: true
           DISPLAY: ':99.0'
         shell: pwsh
@@ -72,7 +72,7 @@ jobs:
       - name: vsce package
         if: runner.os == 'Linux'
         env:
-          BUILD_VERSION: '0.99.${{ github.event.number }}'
+          BUILD_VERSION: 0.99.${{ github.run_number }}
         shell: pwsh
         run: |
           invoke-psake -properties @{ packageVersion = $env:BUILD_VERSION } -tasklist bump

.github/workflows/release.yml

@@ -4,7 +4,7 @@ on:
   workflow_dispatch:
 
 env:
-  NODE_VERSION: '18.x'
+  NODE_VERSION: '20'
 
 jobs:
   release:

.github/workflows/release_prep.yml

@@ -16,7 +16,7 @@ jobs:
     name: "Release Prep"
     runs-on: "ubuntu-latest"
     env:
-      NODE_VERSION: "18"
+      NODE_VERSION: "20"
 
     steps:
       - name: "Checkout"

.github/workflows/vscode-ci.yml

@@ -9,15 +9,15 @@ on:
       - "main"
   workflow_dispatch:
 
-env: 
+env:
   CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
 
 jobs:
   build:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        node-version: [18]
+        node-version: [20]
         os: [ubuntu-latest, windows-latest, macos-latest]
 
     steps:
@@ -76,16 +76,16 @@ jobs:
           npm run test:coverage
 
       - name: Upload Coverage
-        if: | 
-          runner.os == 'Linux' && 
+        if: |
+          runner.os == 'Linux' &&
           env.CODECOV_TOKEN != ''
         uses: codecov/codecov-action@v4
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           files: ./coverage.xml
           fail_ci_if_error: true
           verbose: true
-        
+
       - name: vsce package
         if: runner.os == 'Linux'
         env: