peadm default pe.conf settings conflict with pe_tune

[vchepkov]

pe.conf java args settings added by peadm::generate_pe_conf function are not compatible with pe_tune module.

# cat /etc/puppetlabs/enterprise/conf.d/pe.conf 
{
  "puppet_enterprise::profile::master::java_args": {
    "Xmx": "2048m",
    "Xms": "512m"
  },
  "puppet_enterprise::profile::console::java_args": {
    "Xmx": "768m",
    "Xms": "256m"
  },
  "puppet_enterprise::profile::orchestrator::java_args": {
    "Xmx": "768m",
    "Xms": "256m"
  },
  "puppet_enterprise::profile::puppetdb::java_args": {
    "Xmx": "768m",
    "Xms": "256m"
  }
}

# puppet infrastructure tune --local --pe_conf
# Unable to output optimized settings to: /etc/puppetlabs/enterprise/conf.d/pe.conf: conflicting settings found.

[vchepkov]

cc: @tkishel

[tkishel]

Rather, puppet infra tune avoids merging with existing settings pe.conf as per ...

https://github.com/tkishel/pe_tune/blob/master/lib/puppet_x/puppetlabs/tune.rb#L661

https://github.com/tkishel/pe_tune/blob/master/lib/puppet_x/puppetlabs/tune/peconf.rb#L16

( The error message should probably state existing instead of conflicting settings. )

I added the guard block in PuppetX::Puppetlabs::Tune::PEConf.write() because I was concerned about unintended consequences of a merge with manually-specified tuning in pe.conf.

Perhaps the Installer team could investigate or simply remove the guard block?

[vchepkov]

Ah, right, that's not issue of this module, it's pe_tune's problem. It balks on it's own settings if runs second time. I think this guard should at least have an option to disable it, since it doesn't allow to adjust settings after PE upgrade. I can open issue in pe_tune, if you like @tkishel . thanks

[tkishel]

See tkishel/pe_tune#16