Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of gettext integration #1407

Open
bastelfreak opened this issue Oct 3, 2024 · 4 comments
Open

Status of gettext integration #1407

bastelfreak opened this issue Oct 3, 2024 · 4 comments

Comments

@bastelfreak
Copy link
Contributor

Use Case

I noticed that gettext is used to translate some strings: https://github.com/puppetlabs/r10k/blob/main/locales/r10k.pot

As far as I know this was used in the past to make a translation into Asian languages possible. But that was never implemented. Packaging r10k is a bit painful because of the gettext dependencies. If we could get rid of it because it's not used, that would be nice.

Describe the Solution You Would Like

Let me know if gettext is still used or if I can remove it.

Describe Alternatives You've Considered

A clear and concise description of any alternative solutions or features you've considered.

Additional Context

Add any other context or screenshots about the feature request here.

@bastelfreak
Copy link
Contributor Author

@justinstoller hi! in case the major release is coming soon and you tell me gettext is dead, now might be a good time to rip it out.

@justinstoller
Copy link
Member

Sure, I'll work on removing gettext.

@justinstoller
Copy link
Member

Nevermind, I was told to stop. I believe what to do with our internationalization tooling has been raised up as a question to product, but I don't believe answering that particular question is high on their priorities at the moment. So I'm not sure when it will be answered and we shouldn't block r10k 5 on it.

In the future you can check out my work at main...justinstoller:r10k:no-more-gettext

@bastelfreak
Copy link
Contributor Author

Ah perfect, than I don't have anything else for a 5.0.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants