Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Disable Single Git Source test for el-9, replace 'operatingsystemmajrelease' legacy fact #1360

Merged

Conversation

rileynewton
Copy link
Contributor

@rileynewton rileynewton commented Aug 16, 2023

This test fails on el-9 since xinetd has been removed on the platform. Added https://perforce.atlassian.net/browse/PE-36632 for future work to address the possibility of using systemd instead here.

@rileynewton rileynewton requested a review from a team as a code owner August 16, 2023 21:26
@rileynewton rileynewton changed the base branch from main to 3.x August 16, 2023 21:26
@@ -5,7 +5,7 @@

confine(:to, :platform => 'el')

if fact_on(master, "operatingsystemmajrelease").to_i < 6
if fact_on(master, "operatingsystemmajrelease").to_i < 6 || fact_on(master, "operatingsystemmajrelease").to_i > 8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we should that fact is gonna be there? It's one of the ones removed in puppet 8.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, did it change to something else?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rileynewton rileynewton force-pushed the maint-disable-broken-el9-test branch 2 times, most recently from b968c27 to 7c9c462 Compare August 17, 2023 19:06
@rileynewton
Copy link
Contributor Author

rileynewton commented Aug 17, 2023

Confirmed that os.release.major is correct with this test running on el-9:


CODEMGMT-92 - C59235 - Single Git Source Using "GIT" Transport Protocol

sweet-desk.delivery.puppetlabs.net (redhat9-64-1) 15:59:53$ facter --json "os.release.major"
  {
    "os.release.major": "9"
  }

sweet-desk.delivery.puppetlabs.net (redhat9-64-1) executed in 0.49 seconds

sweet-desk.delivery.puppetlabs.net (redhat9-64-1) 15:59:53$ facter --json "os.release.major"
  {
    "os.release.major": "9"
  }

sweet-desk.delivery.puppetlabs.net (redhat9-64-1) executed in 0.51 seconds

sweet-desk.delivery.puppetlabs.net (redhat9-64-1) 15:59:54$ facter --json "os.release.major"
  {
    "os.release.major": "9"
  }

sweet-desk.delivery.puppetlabs.net (redhat9-64-1) executed in 0.51 seconds

sweet-desk.delivery.puppetlabs.net (redhat9-64-1) 15:59:54$ facter --json "os.release.major"
  {
    "os.release.major": "9"
  }

sweet-desk.delivery.puppetlabs.net (redhat9-64-1) executed in 0.51 seconds

This version of EL is not supported by this test case!
Begin teardown
End teardown
Warning: tests/git_source/git_source_git.rb skipped in 2.03 seconds

Looks good but will double check the rest of the tests and ensure there aren't any quirks.

@rileynewton rileynewton force-pushed the maint-disable-broken-el9-test branch from 7c9c462 to ea4091d Compare August 17, 2023 23:09
@rileynewton rileynewton changed the title (maint) Disable Single Git Source test for el-9 (maint) Disable Single Git Source test for el-9replace 'operatingsystemmajrelease' legacy fact Aug 17, 2023
@rileynewton rileynewton changed the title (maint) Disable Single Git Source test for el-9replace 'operatingsystemmajrelease' legacy fact (maint) Disable Single Git Source test for el-9, replace 'operatingsystemmajrelease' legacy fact Aug 17, 2023
@jonathannewman jonathannewman merged commit d623be1 into puppetlabs:3.x Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants