-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(maint) Disable Single Git Source test for el-9, replace 'operatingsystemmajrelease' legacy fact #1360
(maint) Disable Single Git Source test for el-9, replace 'operatingsystemmajrelease' legacy fact #1360
Conversation
@@ -5,7 +5,7 @@ | |||
|
|||
confine(:to, :platform => 'el') | |||
|
|||
if fact_on(master, "operatingsystemmajrelease").to_i < 6 | |||
if fact_on(master, "operatingsystemmajrelease").to_i < 6 || fact_on(master, "operatingsystemmajrelease").to_i > 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we should that fact is gonna be there? It's one of the ones removed in puppet 8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, did it change to something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
os.release.major
I think is how you'd reference it, see: https://github.com/puppetlabs/classifier/blob/main/src/puppetlabs/classifier/legacy_fact_translation.clj#L104
b968c27
to
7c9c462
Compare
Confirmed that
Looks good but will double check the rest of the tests and ensure there aren't any quirks. |
…stemmajrelease' legacy fact
7c9c462
to
ea4091d
Compare
This test fails on el-9 since xinetd has been removed on the platform. Added https://perforce.atlassian.net/browse/PE-36632 for future work to address the possibility of using systemd instead here.