(maint) Merge branch '3.x' into 'main' & prepare for 4.0.2 release #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if loading module metadata raised an uncaught exception a user with automation that always used `--incremental` could not recover from a failed deployment. One specific case of this is a module without a proper implementation. In that case a RuntimeError is raised. This adds RuntimeError to the metadata loading rescue block.
Some issues that can be encountered when parsing Puppetfile metadata raise R10K::Error. Catch R10K::Errors in metadata parsing.
Parsing metedata, for users who run `--incremental` with every deploy, must not raise exceptions that end deployment. To prevent that we have collected a large list of fairly basic execptions families. This consolidates us to the ScriptError and StandardError exception families, which contained all of the previous exceptions, but still doesn't catch things like SystemExit exceptions.
…g_robustness (PE-34196, PE-34917) Make loading metadata in `--incremental` deploys more robust
(maint) Use production forge for integration tests
Conflicts: - lib/r10k/version.rb
justinstoller
changed the title
|
Figured I'd add an additional commit to prepare a release for these changes. Let me know if you'd like a separate PR. |
donoghuc
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conflicts: