Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer script uses relative paths in compiled program #197

Open
2meito opened this issue Dec 2, 2024 · 4 comments
Open

Installer script uses relative paths in compiled program #197

2meito opened this issue Dec 2, 2024 · 4 comments
Labels
问题修复 请提出你在使用中的BUG与问题

Comments

@2meito
Copy link
Contributor

2meito commented Dec 2, 2024

This causes many issues such as littering .env folders in any directory the script is run.

@Kiramei Kiramei added the 问题修复 请提出你在使用中的BUG与问题 label Dec 2, 2024
@Kiramei
Copy link
Collaborator

Kiramei commented Dec 2, 2024

@2meito Thanks for your comment. Can you provide some further information, such as the log?

@pur1fying
Copy link
Owner

I think some updates for installer is necessary:

  1. It’s better to add a config file for installer.py , users can define install parameters arrcording to their computer enviroment. For example : install python or specify an existing python environment.
  2. Command in installer.py like
 subprocess.run([env_python_exec, '-m', 'pip', 'install', '-r', './requirements.txt', '-i',
         'https://pypi.tuna.tsinghua.edu.cn/simple', '--no-warn-script-location'], check=True)

Mirror site should not be fixed cause it seems some user can't install requriements when the mirror is https://pypi.tuna.tsinghua.edu.cn/simple

@2meito
Copy link
Contributor Author

2meito commented Dec 6, 2024

Sorry for not following up earlier.

If you run the following commands:

cd /home/username/Downloads
sudo dpkg -i  BlueArchiveAutoScript_linux_amd64_v1_1_3.deb
sudo BlueArchiveAutoScript

The script will clone the repository to the /home/username/Downloads and any time you want to run BlueArchiveScript, you will have to cd to the directory, otherwise it will create an new installation in the current directory.

Instead of relative paths, (e.g. ./env/bin/python3), we should use full paths (e.g. \home\username\repositories\blue_archive_auto_script\env\bin\python3).

@Kiramei
Copy link
Collaborator

Kiramei commented Dec 8, 2024

Sorry for not following up earlier.

If you run the following commands:

cd /home/username/Downloads

sudo dpkg -i  BlueArchiveAutoScript_linux_amd64_v1_1_3.deb

sudo BlueArchiveAutoScript

The script will clone the repository to the /home/username/Downloads and any time you want to run BlueArchiveScript, you will have to cd to the directory, otherwise it will create an new installation in the current directory.

Instead of relative paths, (e.g. ./env/bin/python3), we should use full paths (e.g. \home\username\repositories\blue_archive_auto_script\env\bin\python3).

Ah... I see it. I'll try to fix the problem in next few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
问题修复 请提出你在使用中的BUG与问题
Projects
None yet
Development

No branches or pull requests

3 participants