Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some reused code into components #15

Open
MatthewStanciu opened this issue May 16, 2022 · 0 comments
Open

Move some reused code into components #15

MatthewStanciu opened this issue May 16, 2022 · 0 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@MatthewStanciu
Copy link
Member

MatthewStanciu commented May 16, 2022

Especially while building the new past-event.tsx pages (and its related components gallery.tsx, image-card.tsx, image-grid.tsx, and stats-card.tsx (honorable mention to desc-box.tsx, gray-card.tsx, and styled-button.tsx), I copy/pasted a lot of styling instead of making components, usually because the component involved conditional styling and I wanted to ship the project as quickly as possible.

Combining these styles into components is a bit harder than it sounds: because there's conditional styling involved, you need to make a component with base styling and use a library like tailwindcss-clsx, which is used to combine className strings for instances in which you need conditional styling, to add more styles to the components in other parts of the code.

It's probably not a few-minutes project, but it also shouldn't take too long, and it's a great first issue that would help me very much. :)

@MatthewStanciu MatthewStanciu added the good first issue Good for newcomers label May 16, 2022
@ayoaru ayoaru self-assigned this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants