Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query edit: ^W delete-word #280

Open
frasertweedale opened this issue Apr 3, 2019 · 7 comments
Open

Query edit: ^W delete-word #280

frasertweedale opened this issue Apr 3, 2019 · 7 comments

Comments

@frasertweedale
Copy link
Member

Is your feature request related to a problem? Please describe.
Query editing is a bit of a pain. Would be handy if ^W would delete-word, make it a bit faster to use.

@romanofski romanofski added feature and removed feature labels Apr 3, 2019
@romanofski romanofski added this to the Future Feature milestone Apr 3, 2019
@BlackCapCoder
Copy link

Rather than re-implementing all the common terminal shortcuts, it might be better to use Haskeline. This is the library that ghci uses for line editing. It has a global config file that the user can tune to his or her own preferences, and has both emacs and vi keybinds!

@frasertweedale
Copy link
Member Author

@BlackCapCoder yeah it would be nice to combine brick and haskeline...

@romanofski
Copy link
Member

I've found work done here: https://github.com/rootmos/haskeline but the haskeline API is pretty closed at the moment. Therefore I've filed an issue haskell/haskeline#118 to ask what's the better way to get brick support into haskeline.

@romanofski
Copy link
Member

I think we should remove the easyfix tag for this card, since incorporating haskeline is not really an easy fix.

@frasertweedale
Copy link
Member Author

@romanofski agree. Removed tag; changed description to reflect what task has become.

@romanofski
Copy link
Member

So I've hacked on this for a bit using prior work from https://www.rootmos.io/2017-08-31-combining-brick-and-haskeline.html and haskell/haskeline#121. The branch is f2e56a9 but I'm inclined to wait until haskell/haskeline#121 is merged, because without exposed internals in Haskeline, no Brick widget using Haskeline.

@romanofski
Copy link
Member

@frasertweedale maybe more people would ask for haskell/haskeline#121 to be merged? Otherwise we can't really progess with this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants