You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Within the UI code, we have toggledOrSelectedItemHelper for several actions,
including:
updateReadState
completeMailTags
setTags
The helper has the following behaviour:
If there are any items "toggled" on, then the action is applied to the toggled items (bool set to true in the action item)
Otherwise, the action is applied to the selected item (whatever item the Brick list cursor is on)
I propose that we "decompose" this action into separate actions/keybindings for "apply to toggled items"
and "apply to current item". This decomposition would then enable a clean-up of the HasList and HasToggleableList
classes and instances, providing for more ergonomic access and safer handling of items in toggleable lists.
For example, we can avoid exposing the "toggled" state in traversals that targets toggled items.
It may also make some things in the UI less ambiguous as to what items a given operation shall be applied to.
Sounds good. The current state is a "make-it-work" implementation anyways. I guess it would also be useful due to the changes in Brick in the background?
Within the UI code, we have
toggledOrSelectedItemHelper
for several actions,including:
updateReadState
completeMailTags
setTags
The helper has the following behaviour:
I propose that we "decompose" this action into separate actions/keybindings for "apply to toggled items"
and "apply to current item". This decomposition would then enable a clean-up of the
HasList
andHasToggleableList
classes and instances, providing for more ergonomic access and safer handling of items in toggleable lists.
For example, we can avoid exposing the "toggled" state in traversals that targets toggled items.
It may also make some things in the UI less ambiguous as to what items a given operation shall be applied to.
Seeking your feedback @romanofski on this idea.
The text was updated successfully, but these errors were encountered: